Phpbb Primetime


Not your daddy's portal

Phpbb Primetime - Bug tracker

"Apply these changes to these other styles:" - RSS Blocks copy incorrectly (fix completed in svn)

 

I had created a new test style, bringing the total to 3, proFormell (the main one I had used exclusively up to this point), prosilver, and TestStyle. Edited an RSS blocks title (adding it in since it did not copy over as per other bug report) in the TestStyle, selected prosilver in the "Apply these changes to these other styles:" option, then went and check the prosilver blocks and all of the RSS blocks seemed to be replaced by the RSS block that I just edited.

Instead of

RSS Feed 1
RSS Feed 2
RSS Feed 3
...

it is now

RSS Feed 2
RSS Feed 2
RSS Feed 2
...
all the way down replacing all RSS blocks
Last edited by Blitze on October 21st, 2009, 4:02 am, edited 3 times in total.
Reason: This is the blocks module not pages

Comments

Posted by Blitze » October 21st, 2009, 4:01 am

when the option to copy changes is selected, the system checks for module-block combinations and creates them for styles that do not have the block or updates them for styles that have the module-block combination, including the block configuration. Unfortunately, if there is more than one instance of the block for a given style, the changes are applied to all instances. This obviously does not work well for custom blocks where you'd usually have more than one instance. Here are some possible solutions that I am considering:
  1. Only update blocks that have same name, same module, same position, and same weight (0, 1, 2...) as the block being updated and create new block for styles that do not with the same weight. (where weight represents the order in which the blocks are display for a given block position)
  2. Only update general things like position, title, excluded modules, but not block specific configuration settings if block already exists for the selected style(s)
  3. Check if style has more than one instance of the module-block combination. If it does:
    1. Do not update or create new block for the style
    2. Update only one of them (but which one?)
  4. Leave it as it is but provide warning that multiple instances will be overwritten
  5. Remove this feature
What do you think?

Ticket details